Author: markt
Date: Thu Mar 3 16:21:38 2016
New Revision: 1733494
URL: http://svn.apache.org/viewvc?rev=1733494&view=rev
Log:
Fix some JASPIC logging TODOs
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java?rev=1733494&r1=1733493&r2=1733494&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/AuthenticatorBase.java
Thu Mar 3 16:21:38 2016
@@ -459,7 +459,7 @@ public abstract class AuthenticatorBase
String authContextID =
serverAuthConfig.getAuthContextID(messageInfo);
serverAuthContext =
serverAuthConfig.getAuthContext(authContextID, null, null);
} catch (AuthException e) {
- // TODO: i18n log this
+
log.warn(sm.getString("authenticator.jaspicServerAuthContextFail"), e);
response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);
return;
}
@@ -637,7 +637,7 @@ public abstract class AuthenticatorBase
request.setRequest((HttpServletRequest)
messageInfo.getRequestMessage());
response.setResponse((HttpServletResponse)
messageInfo.getResponseMessage());
} catch (AuthException e) {
- // TODO Log this. Change the status code?
+
log.warn(sm.getString("authenticator.jaspicSecureResponseFail"), e);
}
}
}
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties?rev=1733494&r1=1733493&r2=1733494&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/catalina/authenticator/LocalStrings.properties
Thu Mar 3 16:21:38 2016
@@ -20,6 +20,8 @@ authenticator.check.authorizeFail=Realm
authenticator.check.found=Already authenticated [{0}]
authenticator.check.sso=Not authenticated but SSO session ID [{0}] found.
Attempting re-authentication.
authenticator.jaspicCleanSubjectFail=Failed to clean JASPIC subject
+authenticator.jaspicSecureResponseFail=Failed to secure response during JASPIC
processing
+authenticator.jaspicServerAuthContextFail=Failed to obtain a JASPIC
ServerAuthContext instance
authenticator.formlogin=Invalid direct reference to form login page
authenticator.loginFail=Login failed
authenticator.manager=Exception initializing trust managers
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
