Author: markt
Date: Wed Apr 27 09:41:02 2016
New Revision: 1741181
URL: http://svn.apache.org/viewvc?rev=1741181&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
attributes is non-final so it can be replaced. Define the field as
ConcurrentMap to ensure that thread-safety is maintained if this happens.
Modified:
tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
Modified: tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/session/StandardSession.java?rev=1741181&r1=1741180&r2=1741181&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/session/StandardSession.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/session/StandardSession.java Wed Apr
27 09:41:02 2016
@@ -36,6 +36,7 @@ import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.ConcurrentMap;
import java.util.concurrent.atomic.AtomicInteger;
import javax.servlet.ServletContext;
@@ -142,7 +143,7 @@ public class StandardSession implements
/**
* The collection of user data attributes associated with this Session.
*/
- protected Map<String, Object> attributes = new ConcurrentHashMap<>();
+ protected ConcurrentMap<String, Object> attributes = new
ConcurrentHashMap<>();
/**
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
