Author: markt
Date: Wed Apr 27 09:56:53 2016
New Revision: 1741190
URL: http://svn.apache.org/viewvc?rev=1741190&view=rev
Log:
Review of Map / ConcurrentMap / ConcurrentHashMap
Declare field using interface rather than implementation.
Also:
- Use final
Modified:
tomcat/trunk/java/org/apache/catalina/ha/context/ReplicatedContext.java
tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java
Modified:
tomcat/trunk/java/org/apache/catalina/ha/context/ReplicatedContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/context/ReplicatedContext.java?rev=1741190&r1=1741189&r2=1741190&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/ha/context/ReplicatedContext.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/context/ReplicatedContext.java Wed
Apr 27 09:56:53 2016
@@ -132,8 +132,7 @@ public class ReplicatedContext extends S
protected static class ReplApplContext extends ApplicationContext {
- protected final ConcurrentHashMap<String, Object> tomcatAttributes =
- new ConcurrentHashMap<>();
+ protected final Map<String, Object> tomcatAttributes = new
ConcurrentHashMap<>();
public ReplApplContext(ReplicatedContext context) {
super(context);
Modified: tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java?rev=1741190&r1=1741189&r2=1741190&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/tcp/SimpleTcpCluster.java Wed Apr
27 09:56:53 2016
@@ -154,7 +154,7 @@ public class SimpleTcpCluster extends Li
private int channelStartOptions = Channel.DEFAULT;
- private Map<Member,ObjectName> memberOnameMap = new ConcurrentHashMap<>();
+ private final Map<Member,ObjectName> memberOnameMap = new
ConcurrentHashMap<>();
// ------------------------------------------------------------- Properties
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
