Author: kfujino Date: Mon Jun 27 07:44:24 2016 New Revision: 1750291 URL: http://svn.apache.org/viewvc?rev=1750291&view=rev Log: Remove duplicate code. There is no need to release the connection here because the connection is released in subsequent process.
Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java?rev=1750291&r1=1750290&r2=1750291&view=diff ============================================================================== --- tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java (original) +++ tomcat/tc7.0.x/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java Mon Jun 27 07:44:24 2016 @@ -815,8 +815,6 @@ public class ConnectionPool { return con; } else { //validation failed. - release(con); - setToNull = true; throw new SQLException("Failed to validate a newly established connection."); } } catch (Exception x) { Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml?rev=1750291&r1=1750290&r2=1750291&view=diff ============================================================================== --- tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Mon Jun 27 07:44:24 2016 @@ -110,6 +110,14 @@ </fix> </changelog> </subsection> + <subsection name="jdbc-pool"> + <changelog> + <fix> + Fix the duplicated connection release when connection verification + failed. (kfujino) + </fix> + </changelog> + </subsection> </section> <section name="Tomcat 7.0.70 (violetagg)" rtext="released 2016-06-20"> <subsection name="Catalina"> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org