On 05/10/2016 12:32, Mark Thomas wrote: > On 05/10/2016 12:21, Konstantin Kolinko wrote: >> 2016-10-05 13:48 GMT+03:00 <ma...@apache.org>: >>> Author: markt >>> Date: Wed Oct 5 10:48:51 2016 >>> New Revision: 1763403 >>> >>> URL: http://svn.apache.org/viewvc?rev=1763403&view=rev >>> Log: >>> Refactor the web resources handling to use the Tomcat specific >>> 'war:file:...' URL protocol...
<snip/> >>> Modified: tomcat/tc8.5.x/trunk/bin/catalina.bat >>> URL: >>> http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/bin/catalina.bat?rev=1763403&r1=1763402&r2=1763403&view=diff >>> ============================================================================== >>> --- tomcat/tc8.5.x/trunk/bin/catalina.bat (original) >>> +++ tomcat/tc8.5.x/trunk/bin/catalina.bat Wed Oct 5 10:48:51 2016 >>> @@ -201,6 +201,10 @@ set JSSE_OPTS="-Djdk.tls.ephemeralDHKeyS >>> :gotJsseOpts >>> set "JAVA_OPTS=%JAVA_OPTS% %JSSE_OPTS%" >>> >>> +rem Register custom URL handlers >>> +rem Do this here so they can be used in the security policy >> >> Maybe clarify "they"? s/they/war: URLs/ > > Will do. Fixed. >>> +set "JAVA_OPTS=%JAVA_OPTS% >>> -Djava.protocol.handler.pkgs=org.apache.catalina.webresources" >>> + >>> if not "%LOGGING_CONFIG%" == "" goto noJuliConfig >>> set LOGGING_CONFIG=-Dnop >>> if not exist "%CATALINA_BASE%\conf\logging.properties" goto noJuliConfig >>> >> >> Will Tomcat start without above change? (Is it only necessary when >> running with a Security Manager, and policy file uses war: URLs)? > > Yes, Tomcat will start unless you are using a SecurityManager that uses > "war:..." URLs. > >> 1. I am concerned about running Tomcat as service. (I do not see >> changes to tomcat.nsi and to service.bat here). > > Fair point. I'll take a look. We don't configure a security manager so not an issue. >> 3. daemon.sh was not updated as well. Again, we don't configure a security manager so not an issue. Should we ever add running under a security manger as an option for the installer or the daemon then we'd need to take account of this. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
