On 23/06/17 07:24, Huxing Zhang wrote:
> Hi,
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [ X ] Alpha - go ahead and release as 9.0.0.M22
> 
> Unit test passed.
> Our test web application works fine.
> 
> 1. There is a typo in trailers.ResponseTrailers, I will fix that later.
> 2. Actually I have a concern of the trailer field implementation. Should we 
> add an extra whitespace between the trailer field name and trailer field, 
> just to keep align with the head field format?

We should be consistent so no objections to the space being added.

Mark


> 
> In rfc7230 section 4.1.2 says the white space is optional.
> header-field   = field-name ":" OWS field-value OWS
> 
> But right now the format is inconsistent between header and trailer field.
> 
> Examples: 
> 
> Escape character is '^]'.
> GET /examples/servlets/trailers/response HTTP/1.1
> Host: hsf.taobao.net:8180
> User-Agent: curl/7.47.0
> Accept: */*
> 
> HTTP/1.1 200
> Content-Type: text/plain;charset=UTF-8
> Transfer-Encoding: chunked
> Date: Fri, 23 Jun 2017 05:49:14 GMT
> 
> 2b
> This reponse should include trailer fields.
> 0
> x-trailer-2:Trailer value two
> x-trailer-1:Trailer value one
> 
> BTW, Jetty[1] has an white space between trailer field name and value. 
> https://webtide.com/http-trailers-in-jetty/
> 
> ------------------------------------------------------------------
> From:Mark Thomas <ma...@apache.org>
> Time:2017 Jun 21 (Wed) 22:18
> To:Tomcat Developers List <dev@tomcat.apache.org>
> Subject:[VOTE] Release Apache Tomcat 9.0.0.M22
> 
> 
> The proposed Apache Tomcat 9.0.0.M22 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 9.0.0.M21 release are:
> 
> - Add a new JULI FileHandler configuration for specifying the maximum
>   number of days to keep the log files. By default the log files will be
>   kept 90 days.
> 
> - Update the Servlet 4.0 implementation to add support for setting
>   trailer fields for HTTP responses.
> 
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error.
> 
> Along with lots of other bug fixes and improvements
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M22/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1137/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M22/
> 
> The proposed 9.0.0.M22 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M22
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to