https://bz.apache.org/bugzilla/show_bug.cgi?id=61253

--- Comment #2 from Konstantin Kolinko <knst.koli...@gmail.com> ---
Bad idea.

The end user does not need to know that somebody tried a property substitution
here. It is not an error to write literal ${foo}. The correct substitution for
"${foo}" if foo does not exist is "${foo}" (no changes). There is no error
here.

The TLDs files in Standard taglib (JSTL) are an example of this: they have
documentation elements - examples - with a lot of ${}s in them.  The examples
web application uses this library.  You will see a lot of "failed substitution"
occurrences when running it. (I saw them when testing the patch for
CVE-2016-6794)


I do not mind if there is a debug logging for failed substitutions.

I think that logging a warning is a bad idea.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to