-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 7/18/17 9:58 AM, Mark Thomas wrote: > The proposed Apache Tomcat 8.5.18 release is now available for > voting. > > The major changes compared to the 8.5.16 release are: > > - Enable TLS connectors to use Java key stores that contain > multiple keys where each key has a separate password. Based on a > patch by Frank Taffelt. > > - Make asynchronous error handling more robust. In particular > ensure that onError() is called for any registered AsyncListeners > after an I/O error on a non-container thread. > > - Sync SSL session access for the APR connector to prevent errors > when accessing the session. > > > Along with lots of other bug fixes and improvements. > > > It can be obtained from: > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.18/ The > Maven staging repo is: > https://repository.apache.org/content/repositories/orgapachetomcat-114 4/ > > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_18/ > > The proposed 8.5.18 release is: [ ] Broken - do not release [?] > Stable - go ahead and release as 8.5.18 Works fine for me in a development environment. *There was a unit test failure I've never seen before.* Someone who knows more about this particular test might want to weigh-in on whether or not this is a problem. Details below. - -chris * Environment * Java (build): java version "1.8.0_101" Java(TM) SE Runtime Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode) * Java (test): java version "1.8.0_101" Java(TM) SE Runtime Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.101-b13, mixed mode) * OS: Linux 2.6.32-312-ec2 x86_64 * cc: cc (Debian 4.7.2-5) 4.7.2 * make: GNU Make 3.81 * OpenSSL: 1.0.2k * APR: 1.4.6 * * Valid MD5 signature for apache-tomcat-8.5.18.zip * Valid GPG signature for apache-tomcat-8.5.18.zip * Valid MD5 signature for apache-tomcat-8.5.18.tar.gz * Valid GPG signature for apache-tomcat-8.5.18.tar.gz * Valid MD5 signature for apache-tomcat-8.5.18.exe * Valid GPG signature for apache-tomcat-8.5.18.exe * Valid MD5 signature for apache-tomcat-8.5.18-src.zip * Valid GPG signature for apache-tomcat-8.5.18-src.zip * Valid MD5 signature for apache-tomcat-8.5.18-src.tar.gz * Valid GPG signature for apache-tomcat-8.5.18-src.tar.gz * * Binary Zip and tarball: Same * Source Zip and tarball: !! NOT SAME Konstantin pointed-out that the newline-rewriting process in the build is not working properly. No reason to block the release. * Building dependencies returned: 0 * tcnative builds cleanly * Tomcat builds cleanly * Junit Tests: FAILED JUnit test case failures are almost all expected: (a) no multicast and (b) cipher tests are highly dependent upon environment. For TestVirtualContext (which only failed for NIO2, oddly), here are the errors: 20-Jul-2017 12:10:16.422 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2] org.apache.catalina.core.StandardHostValve.invoke Exception Processing null java.lang.NullPointerException at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValv e.java:236) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValv e.java:96) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(Authenticator Base.java:478) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java :140) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java :80) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve. java:87) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:3 42) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:79 9) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight. java:66) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractPro tocol.java:868) at org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun(Nio2Endpoi nt.java:1697) at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.j ava:49) at org.apache.tomcat.util.net.AbstractEndpoint.processSocket(AbstractEndpoi nt.java:946) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:626) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:604) at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:126) at sun.nio.ch.Invoker$2.run(Invoker.java:218) at sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupIm pl.java:112) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav a:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja va:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThrea d.java:61) at java.lang.Thread.run(Thread.java:745) 20-Jul-2017 12:10:16.427 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2] org.apache.coyote.http11.Http11Processor.service Error processing reques t java.lang.NullPointerException at org.apache.catalina.connector.Request.notifyAttributeAssigned(Request.ja va:1555) at org.apache.catalina.connector.Request.setAttribute(Request.java:1541) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java :154) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java :80) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve. java:87) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:3 42) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:79 9) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight. java:66) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractPro tocol.java:868) at org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun(Nio2Endpoi nt.java:1697) at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.j ava:49) at org.apache.tomcat.util.net.AbstractEndpoint.processSocket(AbstractEndpoi nt.java:946) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:626) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:604) at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:126) at sun.nio.ch.Invoker$2.run(Invoker.java:218) at sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupIm pl.java:112) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav a:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja va:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThrea d.java:61) at java.lang.Thread.run(Thread.java:745) 20-Jul-2017 12:10:16.440 SEVERE [http-nio2-127.0.0.1-auto-2-exec-2] org.apache.coyote.http11.Http11Processor.endRequest Error finishing response java.lang.NullPointerException at org.apache.coyote.http11.Http11OutputBuffer.commit(Http11OutputBuffer.ja va:368) at org.apache.coyote.http11.Http11Processor.prepareResponse(Http11Processor .java:1305) at org.apache.coyote.AbstractProcessor.action(AbstractProcessor.java:258) at org.apache.coyote.http11.Http11Processor.endRequest(Http11Processor.java :1474) at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:83 9) at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight. java:66) at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractPro tocol.java:868) at org.apache.tomcat.util.net.Nio2Endpoint$SocketProcessor.doRun(Nio2Endpoi nt.java:1697) at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.j ava:49) at org.apache.tomcat.util.net.AbstractEndpoint.processSocket(AbstractEndpoi nt.java:946) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:626) at org.apache.tomcat.util.net.Nio2Endpoint$Nio2SocketWrapper$4.completed(Ni o2Endpoint.java:604) at sun.nio.ch.Invoker.invokeUnchecked(Invoker.java:126) at sun.nio.ch.Invoker$2.run(Invoker.java:218) at sun.nio.ch.AsynchronousChannelGroupImpl$1.run(AsynchronousChannelGroupIm pl.java:112) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.jav a:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.ja va:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThrea d.java:61) at java.lang.Thread.run(Thread.java:745) ... and then finally: Testcase: testVirtualClassLoader took 14.813 sec Caused an ERROR Read timed out java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.socketRead(SocketInputStream.java:116) at java.net.SocketInputStream.read(SocketInputStream.java:170) at java.net.SocketInputStream.read(SocketInputStream.java:141) at java.io.BufferedInputStream.fill(BufferedInputStream.java:246 ) at java.io.BufferedInputStream.read1(BufferedInputStream.java:28 6) at java.io.BufferedInputStream.read(BufferedInputStream.java:345 ) at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:704) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:647) at sun.net.www.protocol.http.HttpURLConnection.getInputStream0(HttpURLConne ction.java:1536) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnec tion.java:1441) at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:480) at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java :673) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:64 6) at org.apache.catalina.loader.TestVirtualContext.assertPageContains(TestVir tualContext.java:329) at org.apache.catalina.loader.TestVirtualContext.testVirtualClassLoader(Tes tVirtualContext.java:105) That SocketTimeoutException might not be an actual problem. * Tests that failed: * org.apache.catalina.loader.TestVirtualContext.NIO2.txt * org.apache.catalina.session.TestStandardSessionIntegration.APR.txt * org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt * org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt * org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.tx t * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.t xt * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.t xt * org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2. txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt * org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator .APR.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator .NIO.txt * org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator .NIO2.txt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.t xt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.t xt * org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2. txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR .txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO .txt * org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO 2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.APR.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO.txt * org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfiguratio nParser.NIO2.txt -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJZcPHcAAoJEBzwKT+lPKRYiIEP/iQX0HNovesiHRAmHlc2OkSg fbpPCJnPKyWE3A3u1VXt0AG+R6O3pi4WxLmT3mSaLE06ai4EZde+M+kOBLk3wAhW AhIoemHDl4FGy+qq7aV3infmxf2lZ3KxGTO56G8b7FnMkKZyMcDRv9N/qW/kMRlf tqPyIKTonrHA+yHKPfq7bO0Q2HmmLGy5Jd5tS4F6GzM64uvOrSRxMlcXNzXxFXeW fmf/+9XoY6bnOUivngrgZeDZaYc1lCFC0nbkG5xUJe1l/puvaBu2g4x2F2objeVN KNoE9llhHUANYA9lyU236dF555V7lW86pr3IjIssTdGJAqp7xdPMon5TZPdtfd7C 9B6yX7DSg79CyOVJPhPfu04p3njnPgz6VMIr72K8KCLzk7adzwhK7ID/vxFy9QmH WPTbeSBZm17PEknVCNH2uc1ixgpF050uL5mHrFqCsQWIIOZCw8t2O9PsZkVqJ9sH 2ZzsVTEKzU8YMfyUTM/EnqJGbbkRG8i6HVE6uDtucTJF36+WL2tllaWpEkN9xAuA lTtjyl4rLC56DMrjqq/STb2ToCVq19dpGokNi4UcrtkRT1thZ6dLcnv6aY43ffA/ aO/frMhbnThusWxvCjPDVKg1K+xr+QBuvL8XXnf4vPU/XNKAx1RUAjzkpaUi5pT5 l+/NOP09AB0MJ5kW2ozE =UAcM -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
