Author: csutherl Date: Fri Jul 21 19:49:01 2017 New Revision: 1802640 URL: http://svn.apache.org/viewvc?rev=1802640&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=61253
Add warn message when Digester.updateAttributes throws an exception instead of ignoring it. Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java?rev=1802640&r1=1802639&r2=1802640&view=diff ============================================================================== --- tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java (original) +++ tomcat/tc8.5.x/trunk/java/org/apache/tomcat/util/digester/Digester.java Fri Jul 21 19:49:01 2017 @@ -1988,7 +1988,7 @@ public class Digester extends DefaultHan newAttrs.setValue(i, newValue); } } catch (Exception e) { - // ignore - let the attribute have its original value + log.warn("Attribute [" + newAttrs.getLocalName(i) + "] failed to update and remains [" + value + "].", e); } } Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1802640&r1=1802639&r2=1802640&view=diff ============================================================================== --- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Fri Jul 21 19:49:01 2017 @@ -52,6 +52,10 @@ other class loader resources) when the web application is deployed in a packed WAR file. (markt) </fix> + <fix> + <bug>61253</bug>: Add warn message when Digester.updateAttributes + throws an exception instead of ignoring it. (csutherl) + </fix> </changelog> </subsection> <subsection name="Web applications"> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org