On 10/16/2017 2:47 AM, Mark Thomas wrote:
On 15/10/17 20:09, Igal @ Lucee.org wrote:
On 10/15/2017 12:06 PM, Kapil Kumar wrote:
Does that mean I could skip this part!
If you didn't make any changes that can break Tomcat then you can skip
that part, yes.
It can be hard to judge when it is a good idea to run tests and/or which
tests to run - especially for someone new to the code base.
True. I was basing this on the assumption that the OP has not made any
changes at all,
which he later confirmed. I should have kept my statement as "If you
didn't make any changes.".
<snip/>
It is worth ensuring you run the validate target after any changes as
that will pick up a lot of the trivial formatting issues that can make
patches more work to integrate. Also, don't forget to update the
documentation if necessary and to add an entry to the changelog.
I actually realized yesterday that even changes to the documentation can
break the build,
when I forgot to close a `</p>` which caused the XML to be malformed.
Best,
Igal Sapir
Lucee Core Developer
Lucee.org <http://lucee.org/>
