https://bz.apache.org/bugzilla/show_bug.cgi?id=61886

--- Comment #5 from Konstantin Kolinko <knst.koli...@gmail.com> ---
(In reply to Konstantin Kolinko from comment #4)
> > Fixing that appears to have fixed this bug too.
> 
> Confirmed. I cannot reproduce the WARNING message now. Good.

I added some debug/logging code to AsyncStockServlet and can reproduce this
WARNING easily.  This does happen without a SecurityManager.

Two conclusions here:
1. AsyncStockServlet.onError() is:

    public void onError(AsyncEvent event) throws IOException {
        event.getAsyncContext().complete();
    }

This WARNING happens because the complete() call here fails with an
IllegalStateException.

If the call above were wrapped with try/catch, no warning would be printed.


2. There is a typo in AsyncContextImpl.setErrorState()

>                    listener.fireOnError(errorEvent);
>                } catch (Throwable t2) {
>                    ExceptionUtils.handleThrowable(t);
>                    log.warn("onError() failed for listener of type [" +
>                            listener.getClass().getName() + "]", t2);

It should be handleThrowable(t2) instead of (t) above.

Logging a warning here looks excessive.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to