-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 4/27/18 2:09 PM, Mark Thomas wrote: > On 27/04/18 18:19, Christopher Schultz wrote: >> Mark, >> >> On 4/27/18 1:15 PM, ma...@apache.org wrote: >>> Author: markt Date: Fri Apr 27 17:15:00 2018 New Revision: >>> 1830368 >> >>> URL: http://svn.apache.org/viewvc?rev=1830368&view=rev Log: >>> Collapse multiple leading '/' characters to a single '/' in >>> the return value of HttpServletRequest#getContextPath() to >>> avoid issues if the value is used with >>> HttpServletResponse#sendRedirect(). This behaviour is enabled >>> by default and configurable via the new Context attribute >>> allowMultipleLeadingForwardSlashInPath. >> >> Just confirming: the default behavior here matches that of the >> existing behavior before the patch, yes? So this does not break >> backward-compatibility ... it merely adds the option for >> disabling that behavior which wasn't possible, before. > > No. > > Tomcat now collapses leading slashes in the return value for > HttpServletRequest#getContextPath() > > This is a change to the previous behaviour. > > It should be safe since Tomcat treats "///foo//bar" as "/foo/bar" > > It only broke some tests because they were looking for exact > matches in the return values. So while this is technically a "breaking change", anyone relying on it was already going to be having some serious problems that this likely solves rather than anything else. Thanks for the ACK. - -chris -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlrjhlIACgkQHPApP6U8 pFi2AQ//WpM7ZsHkKhLc8MqGI03oK5DoJq+aEExZDSDT/sHc6v16KCOXSk7Lxt9C H0jdD/HvqbAAQxno4oTmeWVJZ8oW4RkvSYNOBHCSUqzeSOV6Ms8gtq9bt0uKf+fn CxnrhLbbvm2ysFVsBE6wy4UZ8oJnuxQaaqmsV5xG60S2KTa+u2DysZmnFYW3oxTp +iKYAwR4/PVMhouQkfbllwiRyLre/SOI28LSksUZ4nunxKJafEqVxSSdqRbJjv6A zhtQh4Fr2UvDntNUeipRQeAYeUGd3Ca9IB7hrOR6GoPDST1FZq+EPCeQyuUvpWLU zKryh0SiaUEnFz9+1+4QnlbGWD63hgqCEKd12wZzhBAG9RehSzbAUnwUCiwlJH0t 2x3x8fkohUIvzrC32JI86VJwRxG+W9qqOTtCsHgT/8moTZ08AZ8BmRslQEO1KreK 7dnwq9S8Zl0pVrvqAP5Pfb1se5l92YN0dwEj0v3uGvHDMJFru0oj23nHIg8hkwzf rh8PGXCQcIqf4AuVQgaiBACxJc4vO+YE0Fk/Rk/+Xic8b9NLhn8LHSBO/z8GAgKS qrmjEZVmubibzYpbfN6EawSfa/4sXoIfFB08voENIgVtARPOAklxieWE2BT7pQPW yq//Amk5StBqwHkFcEhEll7ymKbs62bgUeZSXut/uSQXj5BNRPY= =dnH7 -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
