Author: markt Date: Tue Jul 3 08:59:53 2018 New Revision: 1834932 URL: http://svn.apache.org/viewvc?rev=1834932&view=rev Log: Fix Findbugs warning Avoid problems if there is a concurrent update of the defaultHostName
Modified: tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java Modified: tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java?rev=1834932&r1=1834931&r2=1834932&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java (original) +++ tomcat/trunk/java/org/apache/catalina/mapper/Mapper.java Tue Jul 3 08:59:53 2018 @@ -65,7 +65,7 @@ public final class Mapper { /** * Default host name. */ - private String defaultHostName = null; + private volatile String defaultHostName = null; private volatile MappedHost defaultHost = null; @@ -692,6 +692,7 @@ public final class Mapper { MappingData mappingData) throws IOException { if (host.isNull()) { + String defaultHostName = this.defaultHostName; if (defaultHostName == null) { return; } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org