On 31/07/18 15:05, Christopher Schultz wrote: > Mark, > > On 7/31/18 8:03 AM, ma...@apache.org wrote: >> Author: markt Date: Tue Jul 31 12:03:26 2018 New Revision: 1837133 > >> URL: http://svn.apache.org/viewvc?rev=1837133&view=rev Log: >> Introduce a new class - MultiThrowable - to report exceptions when >> multiple actions are taken where each action may throw an exception >> but all actions are taken before any errors are reported. Use this >> new class when reporting multiple container (e.g. web application) >> failures during start. > > Is it worth adding a mention in the javadoc that this class isn't > threadsafe? Typically, no mention of thread-safety == not thread safe, > but sometimes it's best to be explicit.
Given the likely use cases I'm inclined to agree. I can image someone passing an instance of this to multiple threads. We could make it thread safe but it doesn't need to be at the moment so I opted to avoid the additional complexity for now. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
