Chris,
Thank you for the feedback:
On 10/3/2018 10:01 AM, Christopher Schultz wrote:
On 10/2/18 17:39, isa...@apache.org wrote:
Author: isapir
Date: Tue Oct 2 21:39:57 2018
New Revision: 1842657
URL: http://svn.apache.org/viewvc?rev=1842657&view=rev
Log:
Fixed test cases that errored due to path case sentsitivity on Windows
Perhaps the isWindows() call should be changed to
isCaseInsensitiveFilesystem() instead? Windows isn't the only OS with
case-insensitive filesystems.
The isWindows() method was replaced in r1842664 with
if (JrePlatform.IS_WINDOWS) ...
I'd be happy to add isCaseInsensitiveFilesystem() to JrePlatform, but
while on Windows I know that it is always the case, I don't think that
we can go just by the OS Name for other systems.
We can write a temp file with name "a" and then check if "A" exists or
only "a" does to determine that value.
I can add that to JrePlatform if that makes sense.
Assume.assumeTrue("This test is only expected to trigger an exception on
Windo9ws",
Nit: Trivial typo.
That typo was already there but I missed it. Rainer caught it (probably
while reviewing my patch) and corrected it in r1842659.
Thanks,
Igal
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
