Hi Mladen, very nice idea making things easier for users. I like it. But dots are standard separation characters in host names and host names might not be totally uncommon as jvm routes. I know, that they can be symbolic, but we might break configs or deny using such a simple way of matching routes.
Since the feature jvm_route is not very old, not many people will use it, but still: do you think another character could be better, by not conflicting with fully qualified host names. E.g. what about the pipe symbol, an at sign, a slash or a colon. Maybe the colon or the at sign would be also easy to remember. Regards, Rainer [EMAIL PROTECTED] schrieb: > Author: mturk > Date: Fri Nov 24 01:00:12 2006 > New Revision: 478809 > > URL: http://svn.apache.org/viewvc?view=rev&rev=478809 > Log: > Setup domain name from route name if the route name > contains dot ('.'). The first part before dot will > be used as domain name. This eases the domain sticky > session configuration. > worker.xxx.route=domain1.nonde1 is equivalent to > worker.xxx.route=domain1.nonde1 > worker.xxx.domain=domain1 > > Modified: > tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c > > Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c > URL: > http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?view=diff&rev=478809&r1=478808&r2=478809 > ============================================================================== > --- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original) > +++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Fri Nov 24 > 01:00:12 2006 > @@ -1199,6 +1199,17 @@ > close_workers(p, i, l); > } > else { > + /* Update domain names if jvm_route contains period '.' */ > + for (i = 0; i < num_of_workers; i++) { > + if (!p->lb_workers[i].s->domain[0]) { > + char * id_domain = > strchr(p->lb_workers[i].s->jvm_route, '.'); > + if (id_domain) { > + *id_domain = '\0'; > + strcpy(p->lb_workers[i].s->domain, > p->lb_workers[i].s->jvm_route); > + *id_domain = '.'; > + } > + } > + } > for (i = 0; i < num_of_workers; i++) { > if (JK_IS_DEBUG_LEVEL(l)) { > jk_log(l, JK_LOG_DEBUG, > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
