-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Mark,
On 1/23/19 16:55, VP Brand wrote: > On 23/01/2019 21:48, bugzi...@apache.org wrote: >> https://bz.apache.org/bugzilla/show_bug.cgi?id=62912 >> >> --- Comment #14 from Mark Thomas <ma...@apache.org> --- Created >> attachment 36389 --> >> https://bz.apache.org/bugzilla/attachment.cgi?id=36389&action=edit >> >> Tomcat 9 patch to retain app provided content-type >> >> The application provided content-type is only retained if no >> charset is present. >> > > Thoughts on applying this patch to Tomcat 9? > > Pros: It allows apps to work with both user agents that require > spaces and user agents that require no spaces > > Cons: The switch to passing through the app provided value may > break some user agents and an app change would be required to fix > it. > > The risk looks to be very low but so is the scale of the problem > this fixes. One bug report in a little over 8 years suggests this > is an issue for a small minority of users. > > If anything, I am leaning towards applying the patch. Thoughts? This might be a rat-hole of a question, but why are we implementing the same logic in two different places? o.a.coyote.Response and o.a.catalina.connector.Response? Can we get away with implementing this in only one place or the other? Related: is this code-comment from o.a.coyote.Response#containsHeader accurate? /** * Does the response contain the given header. * <br> * Warning: This method always returns <code>false</code> for Content-Type * and Content-Length. * * @param name The name of the header of interest * * @return {@code true} if the response contains the header. */ - -chris -----BEGIN PGP SIGNATURE----- Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/ iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAlxKA0AACgkQHPApP6U8 pFg1dw//Vhfz1W4MLcuZ09VIxCHPTiAFwNqqfQifkWDVmndsOmqsDX+BF3LBkhOf 50n/7Hk8X9a39NJ49v7m+FivYCN8rEAhc2DGLXY3SNlxrR54CpJnMryvZgulGC5U 2CiGSWpL3OBmyW4FggWu/RnzU1xKwvtc9kBInIXn1Zh0LsaL1C/Dx3evpdKF+YLi apft0km2757khgYsq18D4VOs7pcBpQxogwYLcHKQ56ZWJAO8+aSUcpfuemLcVgnM UH0es2hQF6RYWUf97e0Eu+f/yUcGx2koWLa2/+vO+EnjG4n0t/+/AmOBKZ1zcLeK I4j6ONtlaOpRbd8px56V+ZR86ymYB5KzQkYW5HNjuzh+GdUw5L95vDtXfVCItopK PtBi0k6GeDKuYnoKYBlhv1P0hqx7ywWwv1m2NrTOkVlrhB/DL3ocdrhNpySTSJe1 gjc6TiafLZvdlqFBvAR/HnIz6uY/AVJI3VXmhl/CPpijYub1Cf6QhjNYTUzOtyJL h2jImB4irsal0+0jaqbCe/fo2YPtPlzkWx5ci70cRdbAY85In0sKa3ygEfGuEYhD G6UDWng5vYTp2HX6VlPwX8zON7WUFMpCJX/oDxEeZF7NSYQu8xgBTuTpgveOVrv3 r8EAZcQc62jm9xxPM7Q7goPwSF0auCB4zHBMUxhcTgqD3h1o16w= =qOBc -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
