markt-asf commented on a change in pull request #176: CoyoteAdapter: fix out-of-bounds read in checkNormalize URL: https://github.com/apache/tomcat/pull/176#discussion_r298806534
########## File path: test/org/apache/catalina/connector/TestCoyoteAdapter.java ########## @@ -326,6 +326,7 @@ public boolean isResponseBodyOK() { @Test public void testNormalize01() { doTestNormalize("/foo/../bar", "/bar"); + doTestNormalize("..", null); } Review comment: We aim for one test per method. This would be a candidate for `testNormalize02()` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org