alpire commented on a change in pull request #176: CoyoteAdapter: fix
out-of-bounds read in checkNormalize
URL: https://github.com/apache/tomcat/pull/176#discussion_r299276368
##########
File path: java/org/apache/catalina/connector/CoyoteAdapter.java
##########
@@ -1252,6 +1252,11 @@ public static boolean checkNormalize(MessageBytes
uriMB) {
int pos = 0;
+ // An empty URL is not acceptable
+ if (start == end) {
+ return false;
+ }
+
// Check for '\' and 0
Review comment:
I do not have an input that would trigger a 500 if we removed that check. I
understand the performance consideration, so I'll remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
