> Mark, > > On 11/19/19 07:08, Mark Thomas wrote: >> <snip/> > >>> Is there a particular reason (a) the translations are in a >>> separate JAR file - i.e. not in catalina.jar and (b) they are >>> separated by language? Perhaps the thought was that, knowing that >>> you don't need e.g. Korean means you can remove the JAR file from >>> some kind of bare-ones distribution. > >> Essentially, yes. The intention was to make it easy to use the >> default English text if users didn't need / didn't want the >> translations. > >>> For SSI, at least, I think it makes sense to bundle all the i18n >>> files together in the same JAR file. I'm using the <jarIt> macro >>> to build my JAR file which explicitly <excludes> >>> LocalStrings_*.properties from whatever JAR file is being built. >>> I'd need to change the way that the SSI JAR file is built in >>> order to achieve this. But before doing so, I wanted to get >>> consensus on what to do with these files. > >> Have you removed all the other dependencies? FastHttpDateFormat, >> StringManager, JULI, IOTools etc? > > No, I haven't. I figured this would turn into a bit of a rat hole so I > wanted to discuss before doing anything. > > This is just a first step towards being able to separate SSI. If SSI > isn't required, the JAR file can be removed from the distribution and > the only sloppiness will be that the locallized strings will remain in > other JAR files.
I think that is a reasonable first step. > But for the future, if SSI were indeed able to be separated-out into a > standalone product (with obvious dependencies), this would need to be > resolved. It's fine to kick the can down the road a bit on this > decision and/or action, but I wanted to bring it up before I committed > anything. I'd lean towards kicking the can down the road. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
