markt-asf commented on a change in pull request #223: Log compression URL: https://github.com/apache/tomcat/pull/223#discussion_r353983965
########## File path: java/org/apache/catalina/valves/AccessLogValve.java ########## @@ -37,6 +37,7 @@ import org.apache.juli.logging.LogFactory; import org.apache.tomcat.util.ExceptionUtils; import org.apache.tomcat.util.buf.B2CConverter; +import org.apache.tomcat.util.file.CompressFileUtils; Review comment: Why not use the JULI version since the dependency is already there rather than duplicating the code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
