вт, 10 дек. 2019 г. в 20:34, Mark Thomas <ma...@apache.org>: > > On 10/12/2019 15:23, Mark Thomas wrote: > > On 10/12/2019 15:20, Konstantin Kolinko wrote: > > > <snip/> > > >>>> There is a typo in daemon.sh > >>>> > >>>> -Dcatalina.base="\"$CATALINA_BASE"\" \ > > > > Good catch. > > > > I've just fixed it. Next task is to figure out how badly it breaks things. > > I think I might have got away with this (in terms of impact on the > current releases). > > I did a quick test with the typo in place and a basic test of script > works as does running in a directory with spaces. > > I'm sure there will be some edge cases that are still broken but my > current plan is to pick up that fix in the next release.
I did a quick test using bash that comes with Git for Windows and calling the following simple script that prints its arguments (instead of calling jsvc): [[[ #!/bin/sh echo "Arguments:" while [ $# -gt 0 ] do echo "[$1]" shift done ]]] I was running with JSVC=./args.sh CATALINA_BASE="catalina base" CATALINA_HOME="catalina home" etc. Both variants of quoting result in the same value being printed: [-Dcatalina.base=catalina base] [-Dcatalina.home=catalina home] Thus that typo does not have any consequences. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
