panchenko commented on a change in pull request #232: Fix handling of query
parameters with no value, like `?foo`
URL: https://github.com/apache/tomcat/pull/232#discussion_r365189403
##########
File path: test/org/apache/catalina/core/TestApplicationHttpRequest.java
##########
@@ -354,4 +364,11 @@ protected void doGet(HttpServletRequest req,
HttpServletResponse resp)
}
}
}
+
+ private static boolean objectsEqual(String object1, String object2) {
Review comment:
The code here fails if only the first parameter is `null`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
