martin-g commented on a change in pull request #243: Improved
CloudMembershipService documentation and configuration
URL: https://github.com/apache/tomcat/pull/243#discussion_r380034690
##########
File path:
java/org/apache/catalina/tribes/membership/cloud/DNSMembershipProvider.java
##########
@@ -30,6 +30,61 @@
import org.apache.juli.logging.Log;
import org.apache.juli.logging.LogFactory;
+/**
+ * A {@link org.apache.catalina.tribes.MembershipProvider} that uses DNS to
retrieve the members of a cluster.<br>
+ *
+ * <p>
+ * <strong>Configuration example for Kubernetes</strong>
+ * </p>
+ *
+ * {@code server.xml }
+ *
+ * <pre>
+ * {@code
+ * <Server ...
+ *
+ * <Service ...
+ *
+ * <Engine ...
+ *
+ * <Host ...
+ *
+ * <Cluster className="org.apache.catalina.ha.tcp.SimpleTcpCluster">
+ * <Channel
className="org.apache.catalina.tribes.group.GroupChannel">
+ * <Membership
className="org.apache.catalina.tribes.membership.cloud.CloudMembershipService"
+ *
membershipProviderClassName="org.apache.catalina.tribes.membership.cloud.DNSMembershipProvider"/>
+ * </Channel>
+ * </Cluster>
+ * ...
+ * }
+ * </pre>
+ *
+ * {@code dns-membership-service.yml }
+ *
+ * <pre>
+ * {@code
+ * apiVersion: v1
Review comment:
This is Kubernetes config. Why it is in DNSMembershipProvider ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
