On 10/03/2020 16:06, Konstantin Kolinko wrote: > вт, 10 мар. 2020 г. в 12:13, Violeta Georgieva <violet...@apache.org>: >> >> The proposed Apache Tomcat 7.0.101 release is now available for voting. >> [...] > > FYI, the test org.apache.juli.TestOneLineFormatterMillisPerformance is > broken on Java 6. > 4 out of 11 tests there fail with an exception like this: > [[[ > Testcase: testMillisHandling[4: format[dd-MMM-yyyy HH:mm:ss XXX]] took 0 sec > Caused an ERROR > Illegal pattern character 'X' > java.lang.IllegalArgumentException: Illegal pattern character 'X' > at java.text.SimpleDateFormat.compile(SimpleDateFormat.java:768) > at java.text.SimpleDateFormat.initialize(SimpleDateFormat.java:575) > at java.text.SimpleDateFormat.<init>(SimpleDateFormat.java:500) > at org.apache.juli.DateFormatCache$Cache.<init>(DateFormatCache.java:125) > at org.apache.juli.DateFormatCache$Cache.<init>(DateFormatCache.java:102) > at org.apache.juli.DateFormatCache.<init>(DateFormatCache.java:91) > at > org.apache.juli.OneLineFormatter.setTimeFormat(OneLineFormatter.java:111) > at > org.apache.juli.TestOneLineFormatterMillisPerformance.testMillisHandling(TestOneLineFormatterMillisPerformance.java:58) > ]]] > > The 'X' (TimeZone) pattern support was added to SimpleDateFormat in Java 7. > Javadoc for SimpleDateFormat for Java 6 and Java 7: > https://docs.oracle.com/javase/6/docs/api/java/text/SimpleDateFormat.html > https://docs.oracle.com/javase/7/docs/api/java/text/SimpleDateFormat.html > > It is not a showstopper, just a broken test. BTW, I wonder why this > test runs at build time at all - there are no assertions there. It > just prints a message to System.out.
Thanks. I've got a fix for that that I'll push shortly. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
