https://bz.apache.org/bugzilla/show_bug.cgi?id=64290
--- Comment #6 from Michael Osipov <micha...@apache.org> --- (In reply to Markus Schlegel from comment #3) > "Do you > org.apache.tomcat.util.http.fileupload.FileUploadBase. > FileSizeLimitExceededException from #getCause()?" > > We are using Tomcat Embedded and we have built a Jax-Rs resource for the > Fileupload, which relies on the org.apache.tomcat.util.http.fileupload.* > classes. Very bad, you should solely rely on Servet API > From org.apache.tomcat.util.http.fileupload.package-info.java I can read: > "While this package provides the generic functionality for file uploads, > these classes are not typically used directly. Instead, normal usage > involves one of the provided extensions of ...." > > This 1.) does not state, that this is not part of the official API and > 2.) is not obvious for a developer using one of the classes/innerclasses > inside the package. Granted. > The refactored new version of it makes it better, because it places > inofficial classes inside an "impl" package, which makes that facto obvious. > > After all, the changed code is what it should look like, but you should not > do this with incompatible changes in a minor release and even worse, not > without notice in the changelog. Fully agree. > If you think this kind of problem is isolated to our special usecase, then > no further action may be required, since we can change our maintenance code > to not rely on that classes anymore. Please do so regardless of this issue. At the end, if you want to be stable or use explicit exceptions, use Commons File Upload directly. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
