Hey All (particularly Markt whom I spoke with about this months and months
ago),

Noting that bnd was already added to the build I took a crack at making
better use of it.

Here are a few items and some questions in no particular order:

- you don't use bndlib, can we remove that? bnd is fully standalone for
your purposes and is all you need
- bootstrap.jar in master seems to be missing the class
`org.apache.tomcat.util.ExceptionUtils` at least from a dependency analysis
point of view, should it be included in the files list?
- tomcat-embed-core.jar appears to be missing tribes dependency (at least
it refers to it but does not include it) Shouldn't it really contain all of
catalina (minus catalina-ant?)
- files.tomcat-embed-core seems to reference an old package
org/apache/jk/**, can we remove that?
- I've split out the i18n LocalStrings_* (the locale specific ones) into a
separate output dir so that you wouldn't have to then filter them out, it
makes building their zips also cleaner, does that sound logical?
- I moved a slew of concerns that bnd could handle out of ant and directly
into the bnd configurations, manifest filtering, etc., bnd has filtering
capability built in and knows about all ant properties so this eliminates
ant work, comments on that?
- generated all the Name sections for spec API packages instead of
maintaining those by hand (now they are complete)
- add all the correct OSGi metadata of course to the spec jars and to
everyone else.
- I've added bnd's JPMS build support to all the modules, still builds on
Java 8, and you get JPMS module-info almost for free (very small amount of
configurable bits)

Could someone provide the build instruction I'd need to do the most
throughout test build? I see that there's a .travis script which does `ant
-q test 2>&1 > ant-test.log` is that really all?

Shall I create an SVN branch to explore this? Or would a git PR be enough?
-- 
*Raymond Augé* <http://www.liferay.com/web/raymond.auge/profile>
 (@rotty3000)
Senior Software Architect *Liferay, Inc.* <http://www.liferay.com>
 (@Liferay)

Reply via email to