markt-asf commented on a change in pull request #303: URL: https://github.com/apache/tomcat/pull/303#discussion_r441648490
########## File path: build.properties.default ########## @@ -286,14 +286,14 @@ saaj-api.home=${base.path}/saaj-api-${saaj-api.version} saaj-api.jar=${saaj-api.home}/saaj-api-${saaj-api.version}.jar saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-api-${saaj-api.version}.jar -# ----- bnd & bndlib, version 4.0.0 or later ----- +# ----- bnd, version 5.1.1 or later ----- Review comment: Is this really an increase in the minimum version? Or is 5.1.0 (with the fix for the Java 15 bug) sufficient? ########## File path: build.properties.default ########## @@ -286,14 +286,14 @@ saaj-api.home=${base.path}/saaj-api-${saaj-api.version} saaj-api.jar=${saaj-api.home}/saaj-api-${saaj-api.version}.jar saaj-api.loc=${base-maven.loc}/javax/xml/soap/saaj-api/${saaj-api.version}/saaj-api-${saaj-api.version}.jar -# ----- bnd & bndlib, version 4.0.0 or later ----- +# ----- bnd, version 5.1.1 or later ----- # ----- provides OSGI metadata for JARs ----- -bnd.version=5.1.0 +bnd.version=5.1.1 # checksums for biz.aQute.bnd-5.1.0.jar Review comment: You need to update the version in the comment for consistency. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org