rmaucher commented on pull request #307: URL: https://github.com/apache/tomcat/pull/307#issuecomment-649522279
Looks good to me. Personally, I don't panic when I see a few random failures. Since this is meant as a smoke test, and in an effort to not spam too much about failures, I would do the following: - Only test trunk (development is supposed to happen there, so although there are backport problems sometimes, this is not that common and will be caught by the main CI rather quickly) - Use "test-nio", for some reason you use "test-nio2" which is not the default connector; but good idea on not testing all three connectors (or rather all six if you also include the JSSE/OpenSSL options - Exclude tests that need a long time to run ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
