karlvr commented on a change in pull request #30:
URL: https://github.com/apache/tomcat-maven-plugin/pull/30#discussion_r459138051
##########
File path:
tomcat9-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat9/run/RunMojo.java
##########
@@ -479,18 +480,23 @@ private WebResource urlToWebResource( URL url, String
path )
jarFile = new JarFile( filePath );
JarEntry jarEntry = jarFile.getJarEntry(
StringUtils.removeStart( path, "/" ) );
-
+/*
return new JarResource( this, //
getPath(), //
filePath, //
url.getPath().substring( 0, idx ), //
jarEntry, //
"", //
null );
+ */
+
+ JarResourceSet jr = new
JarResourceSet(context.getResources(), getPath(), filePath, getPath());
Review comment:
@liudongmiao I think that particular line might have gone in the merge
from my code... if not, could you please explain what you're seeing that's
wrong here? The `JarResourceSet` parameters are a little opaque to me, so I'd
appreciate some more explanation!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
