markt-asf commented on pull request #330: URL: https://github.com/apache/tomcat/pull/330#issuecomment-672078710
There needs to be a *really* good reason to essentially introduce a Tomcat specific extension to the Jakarta WebSocket specification and thie PR hasn't (yet) provided such a justification. If there is a good reason for adding this feature then it would be better added via the Jakarta WebSocket project where the various edge cases can be addressed. My reading of this patch is once the idle event has been fired once, it will fire every time `WsSession.checkExpiration()` is called unless the associated handler sends a message. That seems pointless so I assume the intention is that the handler will send a message when the event fires. The end result is that a message will be sent at least every timeout milliseconds and the session will never timeout. There are simpler ways to ensure an endpoint sends a message every x milliseconds. Absent a suitable justification for adding the feature, this PR is likely to be closed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
