Michael, On Sun, Aug 16, 2020 at 11:37 AM Michael Osipov <micha...@apache.org> wrote:
> Am 2020-08-16 um 20:05 schrieb isa...@apache.org: > > This is an automated email from the ASF dual-hosted git repository. > > > > isapir pushed a commit to branch master > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > > > The following commit(s) were added to refs/heads/master by this push: > > new 9c5d2e3 Extracted CSS styles to external file for better code > mainenance > > 9c5d2e3 is described below > > > > commit 9c5d2e3b633fdb651bc9f11db4aac97ad3ad4df2 > > Author: Igal Sapir <isa...@apache.org> > > AuthorDate: Sun Aug 16 11:05:05 2020 -0700 > > > > Extracted CSS styles to external file for better code mainenance > > > > Also replaced gif logo with svg > > --- > > java/org/apache/catalina/manager/Constants.java | 79 +- > > There is a slight problem to that: TOMCAT_CSS is shared throughout the > codebase. Do you want to break that up in CSS modules or duplicate code? > The new file "manager.css" includes the code from TOMCAT_CSS, which is really just a few lines of CSS [1]. We can certainly add another file with just that but IMO it would be an overkill and would result in an additional unnecessary http request. Igal [1] https://github.com/apache/tomcat/blob/69602cb1ef0dc3aa2188a1b3be9fa3a1440cd1b1/java/org/apache/catalina/util/TomcatCSS.java#L25 > > M > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
