markt-asf commented on pull request #342: URL: https://github.com/apache/tomcat/pull/342#issuecomment-678219905
What is the benefit of this? The `VersionLoggerListener` already logs individual command line arguments by default. The advantages of this over logging `CATALINA_OPTS` are: - it shows all the command line arguments regardless of how they are set (`JAVA_OPTS`, `CATALINA_OPTS`, script modification etc) - it allows users to confirm that environment variables such as `CATALINA_OPTS` have been parsed as intended. Incorrect quoting and escaping is a common cause of `CATALINA_OPTS` related issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
