This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new c6bab9b Fix intermittent CI failure
c6bab9b is described below
commit c6bab9b72ffb9f52af796f39bc7f742db0f418ab
Author: Mark Thomas <[email protected]>
AuthorDate: Thu Aug 27 15:10:46 2020 +0100
Fix intermittent CI failure
---
test/org/apache/coyote/http2/TestHttp2Section_5_1.java | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/test/org/apache/coyote/http2/TestHttp2Section_5_1.java
b/test/org/apache/coyote/http2/TestHttp2Section_5_1.java
index 5101ff4..e8ca217 100644
--- a/test/org/apache/coyote/http2/TestHttp2Section_5_1.java
+++ b/test/org/apache/coyote/http2/TestHttp2Section_5_1.java
@@ -402,22 +402,28 @@ public class TestHttp2Section_5_1 extends Http2TestBase {
, output.getTrace());
output.clearTrace();
- sendLargeGetRequest(3);
-
- sendSimpleGetRequest(5);
-
// Default connection window size is 64k-1.
// Initial request will have used 8k leaving 56k-1.
// Stream window will be 64k-1.
// Increase Connection window by 16k
+ // Do this before sending the requests to ensure the connection window
+ // is increased before request processing starts else stream 5 may
+ // consume the connection window before the update is processed which
+ // will result in at least one addition body frame and break the tests
+ // below.
sendWindowUpdate(0, 16 * 1024);
+ sendLargeGetRequest(3);
+
+ sendSimpleGetRequest(5);
+
// Expecting
// 1 * headers
// 64k-1 of body (8 * ~8k)
// 1 * error
// Could be in any order
+ //
for (int i = 0; i < 9; i++) {
parser.readFrame(true);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
