martin-g commented on a change in pull request #346:
URL: https://github.com/apache/tomcat/pull/346#discussion_r478870589
##########
File path: java/org/apache/tomcat/websocket/Constants.java
##########
@@ -114,6 +114,22 @@
// Milliseconds so this is 20 seconds
public static final long DEFAULT_BLOCKING_SEND_TIMEOUT = 20 * 1000;
+ // Configuration for idle read timeout on websocket channel
+ public static final String WS_READ_IDLE_TIMEOUT =
+ "org.apache.tomcat.websocket.WS_READ_IDLE_TIMEOUT";
+
+ // Configuration for idle write timeout on websocket channel
+ public static final String WS_WRITE_IDLE_TIMEOUT =
+ "org.apache.tomcat.websocket.WS_WRITE_IDLE_TIMEOUT";
+
+ // Configuration for idle write timeout on websocket channel
Review comment:
This comment is exactly the same as for the previous constant
##########
File path: java/org/apache/tomcat/websocket/Constants.java
##########
@@ -114,6 +114,22 @@
// Milliseconds so this is 20 seconds
public static final long DEFAULT_BLOCKING_SEND_TIMEOUT = 20 * 1000;
+ // Configuration for idle read timeout on websocket channel
+ public static final String WS_READ_IDLE_TIMEOUT =
+ "org.apache.tomcat.websocket.WS_READ_IDLE_TIMEOUT";
+
+ // Configuration for idle write timeout on websocket channel
+ public static final String WS_WRITE_IDLE_TIMEOUT =
+ "org.apache.tomcat.websocket.WS_WRITE_IDLE_TIMEOUT";
+
+ // Configuration for idle write timeout on websocket channel
+ public static final String WS_CLOSE_READ_IDLE_TIMEOUT =
+ "org.apache.tomcat.websocket.WS_CLOSE_READ_IDLE_TIMEOUT";
+
+ // Configuration for idle write timeout on websocket channel
Review comment:
Same copy/paste error here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
