kamnani commented on a change in pull request #351: URL: https://github.com/apache/tomcat/pull/351#discussion_r482622880
########## File path: java/org/apache/jasper/EmbeddedServletOptions.java ########## @@ -635,6 +648,19 @@ public EmbeddedServletOptions(ServletConfig config, ServletContext context) { } } + String jspWhiteSpaceTrim = config.getInitParameter("JSPWhiteSpaceTrimming"); + if (jspWhiteSpaceTrim != null) { + if (jspWhiteSpaceTrim.equalsIgnoreCase("true")) { + this.JSPWhiteSpaceTrimming = true; + } else if (jspWhiteSpaceTrim.equalsIgnoreCase("false")) { + this.JSPWhiteSpaceTrimming = false; + } else { + if (log.isWarnEnabled()) { + log.warn(Localizer.getMessage("Invalid Value for the flag")); Review comment: Yes, I think we can add the name of the flag. That can be done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org