kamnani commented on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-696807874


   @markt-asf 
   
   I am sure you wouldn't be able to test this on proprietary code, because 
that will generate empty outputs/compile-errors after stripping out the 
important lines.
   
   I am attaching the JSP from the tomcat code itself, and the results will be 
quite evident once you use the flag in this PR. 
   
   This is the index.jsp file from the ROOT web application in tomcat's code. 
You can use both the parameters and see the difference they exhibit. Also, do 
make sure to clear out the work folder after testing any of the parameter just 
to clear out the cache. 
   
   ```
   <%--
   Licensed to the Apache Software Foundation (ASF) under one or more
   contributor license agreements.  See the NOTICE file distributed with
   this work for additional information regarding copyright ownership.
   The ASF licenses this file to You under the Apache License, Version 2.0
   (the "License"); you may not use this file except in compliance with
   the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing, software
   distributed under the License is distributed on an "AS IS" BASIS,
   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
   See the License for the specific language governing permissions and
   limitations under the License.
   --%>
   <%@ page session="false" pageEncoding="UTF-8" contentType="text/html; 
charset=UTF-8" %>
   <%
   java.text.SimpleDateFormat sdf = new java.text.SimpleDateFormat("yyyy");
   request.setAttribute("year", sdf.format(new java.util.Date()));
   request.setAttribute("tomcatUrl", "https://tomcat.apache.org/";);
   request.setAttribute("tomcatDocUrl", "/docs/");
   request.setAttribute("tomcatExamplesUrl", "/examples/");
   %>
   <!DOCTYPE html>
   <html lang="en">
       <head>
           <meta charset="UTF-8" />
           <title><%=request.getServletContext().getServerInfo() %></title>
           <link href="favicon.ico" rel="icon" type="image/x-icon" />
           <link href="favicon.ico" rel="shortcut icon" type="image/x-icon" />
           <link href="tomcat.css" rel="stylesheet" type="text/css" />
       </head>
   
       <body>
           <div id="wrapper">
               <div id="navigation" class="curved container">
                   <span id="nav-home"><a href="${tomcatUrl}">Home</a></span>
                   <span id="nav-hosts"><a 
href="${tomcatDocUrl}">Documentation</a></span>
                   <span id="nav-config"><a 
href="${tomcatDocUrl}config/">Configuration</a></span>
                   <span id="nav-examples"><a 
href="${tomcatExamplesUrl}">Examples</a></span>
                   <span id="nav-wiki"><a 
href="https://wiki.apache.org/tomcat/FrontPage";>Wiki</a></span>
                   <span id="nav-lists"><a 
href="${tomcatUrl}lists.html">Mailing Lists</a></span>
                   <span id="nav-help"><a href="${tomcatUrl}findhelp.html">Find 
Help</a></span>
                   <br class="separator" />
               </div>
               <div id="asf-box">
                   <h1>${pageContext.servletContext.serverInfo}</h1>
               </div>
               <div id="upper" class="curved container">
                   <div id="congrats" class="curved container">
                       <h2>If you're seeing this, you've successfully installed 
Tomcat. Congratulations!</h2>
                   </div>
                   <div id="notice">
                       <img src="tomcat.png" alt="[tomcat logo]" />
                       <div id="tasks">
                           <h3>Recommended Reading:</h3>
                           <h4><a 
href="${tomcatDocUrl}security-howto.html">Security Considerations 
How-To</a></h4>
                           <h4><a 
href="${tomcatDocUrl}manager-howto.html">Manager Application How-To</a></h4>
                           <h4><a 
href="${tomcatDocUrl}cluster-howto.html">Clustering/Session Replication 
How-To</a></h4>
                       </div>
                   </div>
                   <div id="actions">
                       <div class="button">
                           <a class="container shadow" 
href="/manager/status"><span>Server Status</span></a>
                       </div>
                       <div class="button">
                           <a class="container shadow" 
href="/manager/html"><span>Manager App</span></a>
                       </div>
                       <div class="button">
                           <a class="container shadow" 
href="/host-manager/html"><span>Host Manager</span></a>
                       </div>
                   </div>
                   <br class="separator" />
               </div>
               <div id="middle" class="curved container">
                   <h3>Developer Quick Start</h3>
                   <div class="col25">
                       <div class="container">
                           <p><a href="${tomcatDocUrl}setup.html">Tomcat 
Setup</a></p>
                           <p><a href="${tomcatDocUrl}appdev/">First Web 
Application</a></p>
                       </div>
                   </div>
                   <div class="col25">
                       <div class="container">
                           <p><a href="${tomcatDocUrl}realm-howto.html">Realms 
&amp; AAA</a></p>
                           <p><a 
href="${tomcatDocUrl}jndi-datasource-examples-howto.html">JDBC 
DataSources</a></p>
                       </div>
                   </div>
                   <div class="col25">
                       <div class="container">
                           <p><a href="${tomcatExamplesUrl}">Examples</a></p>
                       </div>
                   </div>
                   <div class="col25">
                       <div class="container">
                           <p><a 
href="https://wiki.apache.org/tomcat/Specifications";>Servlet 
Specifications</a></p>
                           <p><a 
href="https://wiki.apache.org/tomcat/TomcatVersions";>Tomcat Versions</a></p>
                       </div>
                   </div>
                   <br class="separator" />
               </div>
               <div id="lower">
                   <div id="low-manage" class="">
                       <div class="curved container">
                           <h3>Managing Tomcat</h3>
                           <p>For security, access to the <a 
href="/manager/html">manager webapp</a> is restricted.
                           Users are defined in:</p>
                           <pre>$CATALINA_HOME/conf/tomcat-users.xml</pre>
                           <p>In Tomcat 10.0 access to the manager application 
is split between
                              different users. &nbsp; <a 
href="${tomcatDocUrl}manager-howto.html">Read more...</a></p>
                           <br />
                           <h4><a 
href="${tomcatDocUrl}RELEASE-NOTES.txt">Release Notes</a></h4>
                           <h4><a 
href="${tomcatDocUrl}changelog.html">Changelog</a></h4>
                           <h4><a href="${tomcatUrl}migration.html">Migration 
Guide</a></h4>
                           <h4><a href="${tomcatUrl}security.html">Security 
Notices</a></h4>
                       </div>
                   </div>
                   <div id="low-docs" class="">
                       <div class="curved container">
                           <h3>Documentation</h3>
                           <h4><a href="${tomcatDocUrl}">Tomcat 10.0 
Documentation</a></h4>
                           <h4><a href="${tomcatDocUrl}config/">Tomcat 10.0 
Configuration</a></h4>
                           <h4><a 
href="https://wiki.apache.org/tomcat/FrontPage";>Tomcat Wiki</a></h4>
                           <p>Find additional important configuration 
information in:</p>
                           <pre>$CATALINA_HOME/RUNNING.txt</pre>
                           <p>Developers may be interested in:</p>
                           <ul>
                               <li><a 
href="https://tomcat.apache.org/bugreport.html";>Tomcat 10.0 Bug 
Database</a></li>
                               <li><a 
href="${tomcatDocUrl}api/index.html">Tomcat 10.0 JavaDocs</a></li>
                               <li><a 
href="https://github.com/apache/tomcat/tree/master";>Tomcat 10.0 Git Repository 
at GitHub</a></li>
                           </ul>
                       </div>
                   </div>
                   <div id="low-help" class="">
                       <div class="curved container">
                           <h3>Getting Help</h3>
                           <h4><a href="${tomcatUrl}faq/">FAQ</a> and <a 
href="${tomcatUrl}lists.html">Mailing Lists</a></h4>
                           <p>The following mailing lists are available:</p>
                           <ul>
                               <li id="list-announce"><strong><a 
href="${tomcatUrl}lists.html#tomcat-announce">tomcat-announce</a><br />
                                   Important announcements, releases, security 
vulnerability notifications. (Low volume).</strong>
                               </li>
                               <li><a 
href="${tomcatUrl}lists.html#tomcat-users">tomcat-users</a><br />
                                   User support and discussion
                               </li>
                               <li><a 
href="${tomcatUrl}lists.html#taglibs-user">taglibs-user</a><br />
                                   User support and discussion for <a 
href="${tomcatUrl}taglibs/">Apache Taglibs</a>
                               </li>
                               <li><a 
href="${tomcatUrl}lists.html#tomcat-dev">tomcat-dev</a><br />
                                   Development mailing list, including commit 
messages
                               </li>
                           </ul>
                       </div>
                   </div>
                   <br class="separator" />
               </div>
               <div id="footer" class="curved container">
                   <div class="col20">
                       <div class="container">
                           <h4>Other Downloads</h4>
                           <ul>
                               <li><a 
href="${tomcatUrl}download-connectors.cgi">Tomcat Connectors</a></li>
                               <li><a 
href="${tomcatUrl}download-native.cgi">Tomcat Native</a></li>
                               <li><a 
href="${tomcatUrl}taglibs/">Taglibs</a></li>
                               <li><a 
href="${tomcatDocUrl}deployer-howto.html">Deployer</a></li>
                           </ul>
                       </div>
                   </div>
                   <div class="col20">
                       <div class="container">
                           <h4>Other Documentation</h4>
                           <ul>
                               <li><a href="${tomcatUrl}connectors-doc/">Tomcat 
Connectors</a></li>
                               <li><a href="${tomcatUrl}connectors-doc/">mod_jk 
Documentation</a></li>
                               <li><a href="${tomcatUrl}native-doc/">Tomcat 
Native</a></li>
                               <li><a 
href="${tomcatDocUrl}deployer-howto.html">Deployer</a></li>
                           </ul>
                       </div>
                   </div>
                   <div class="col20">
                       <div class="container">
                           <h4>Get Involved</h4>
                           <ul>
                               <li><a 
href="${tomcatUrl}getinvolved.html">Overview</a></li>
                               <li><a href="${tomcatUrl}source.html">Source 
Repositories</a></li>
                               <li><a href="${tomcatUrl}lists.html">Mailing 
Lists</a></li>
                               <li><a 
href="https://wiki.apache.org/tomcat/FrontPage";>Wiki</a></li>
                           </ul>
                       </div>
                   </div>
                   <div class="col20">
                       <div class="container">
                           <h4>Miscellaneous</h4>
                           <ul>
                               <li><a 
href="${tomcatUrl}contact.html">Contact</a></li>
                               <li><a 
href="${tomcatUrl}legal.html">Legal</a></li>
                               <li><a 
href="https://www.apache.org/foundation/sponsorship.html";>Sponsorship</a></li>
                               <li><a 
href="https://www.apache.org/foundation/thanks.html";>Thanks</a></li>
                           </ul>
                       </div>
                   </div>
                   <div class="col20">
                       <div class="container">
                           <h4>Apache Software Foundation</h4>
                           <ul>
                               <li><a href="${tomcatUrl}whoweare.html">Who We 
Are</a></li>
                               <li><a 
href="${tomcatUrl}heritage.html">Heritage</a></li>
                               <li><a href="https://www.apache.org";>Apache 
Home</a></li>
                               <li><a 
href="${tomcatUrl}resources.html">Resources</a></li>
                           </ul>
                       </div>
                   </div>
                   <br class="separator" />
               </div>
               <p class="copyright">Copyright &copy;1999-${year} Apache 
Software Foundation.  All Rights Reserved</p>
           </div>
       </body>
   
   </html>
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to