https://bz.apache.org/bugzilla/show_bug.cgi?id=64872

--- Comment #6 from John Engebretson <jeng...@amazon.com> ---
We have a Tomcat8 implementation deployed that addresses the following cases:

Boolean/boolean properties:
value="true"
value="${true}"
value="${'true'}"

String properties:
value="${'myString'}"

Enum properties:
value="hotFudge"
value="${'hotFudge'}"

We considered the literal conversions to be quite safe, but the others were
debated. 
- For booleans we decided that anyone who wrote true but wanted false could fix
their own problem.
- For enums, our codebase contained many places where engineers forgot to use
the literal syntax, so there was substantial value in taking a risk.  We
settled on applying the optimization when the string matched the name of an
enum value, else allow the current EL evaluation to occur as normal.  The
optimized JSPs would clearly reflect the author's intent when valid but
fallback to previous behavior when intent wasn't clear.

We are satisfied with the balance we struck, but I'm interested in your take.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to