ChristopherSchultz commented on a change in pull request #380:
URL: https://github.com/apache/tomcat/pull/380#discussion_r535327550
##########
File path: java/org/apache/tomcat/util/net/SecureNio2Channel.java
##########
@@ -70,6 +73,8 @@
protected boolean closed;
protected boolean closing;
+ private Map<String,List<String>> additionalTlsAttributes = new HashMap<>();
Review comment:
Is there a reason to use a Map of String-Lists here, instead of having a
more concrete object with well-defined members? Hash maps are quick, but since
we know the "names" of these things in advance, why not use a custom class for
this purpose?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
