Hi Rémy, On Mon, Dec 14, 2020 at 10:51 PM Mark Thomas <ma...@apache.org> wrote:
> On 14/12/2020 11:06, Martin Grigorov wrote: > > On Mon, Dec 14, 2020 at 12:30 PM Rémy Maucherat <r...@apache.org> wrote: > > > >> On Mon, Dec 14, 2020 at 8:53 AM Martin Grigorov <mgrigo...@apache.org> > >> wrote: > >> > >>> Hi Tomcat team, > >>> > >>> The following tests fail on JDK 16 b28: > >>> > >> > >> Ok, so I installed JDK 16 and tested. No issues overall, nice ! > >> > >> About this particular one however, the proper exceptions are now caught > and > >> everything (so it's "ok") but it's not possible to make the > functionality > >> work anymore by default. So the executor and its threads are still > hanging, > >> causing the assertions to fail [as well as the traces when stopping the > >> blocked threads]. Should we relax module security somehow to allow the > >> fields setAccessible(true) to work again ? [that doesn't sound like a > great > >> plan to me ...] > >> > > > > One can work it around by adding --add-opens=java.base/java. > > <http://java.io/>util.concurrent=ALL-UNNAMED to the JVM arguments > > I am not sure whether some module-info.java hackery can make it better. > > This is what we currently do: > > https://github.com/apache/tomcat/blob/master/bin/catalina.sh#L313 > > (and the same for .bat). Looks like we need to add another entry there. > Your fix <https://github.com/apache/tomcat/commit/f42f1899eda28244218bf4d29602bc99574d4486> does not solve the issue for me. Do the tests pass for you with JDK 16 b28 ? diff --git build.xml build.xml index 2c2b532..2c1a54f 100644 --- build.xml +++ build.xml @@ -220,7 +220,7 @@ <property name="java9.test.option.3" value="-Dtest.3=3"/> <available classname="java.lang.reflect.InaccessibleObjectException" property="java9.test.option.4" - value="--add-opens=java.base/java.util=ALL-UNNAMED"/> + value="--add-opens=java.base/java.util.concurrent=ALL-UNNAMED"/> <property name="java9.test.option.4" value="-Dtest.4=4"/> ^^ this fixes them! > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > >
