https://bz.apache.org/bugzilla/show_bug.cgi?id=65181
--- Comment #3 from Christopher Schultz <ch...@christopherschultz.net> --- A quick review: > ... > && tcn_ssl_engine && > (c->keys[idx] = ENGINE_load_private_key(tcn_ssl_engine, key_file, > NULL, NULL)) == NULL This will attempt to use the tcn_ssl_engine pointer to load the private key, but only if the pointer is non-zero. If you mean NULL, you should explicitly compare the pointer to NULL. Otherwise the patch looks reasonable to me. I assume you've tested it to make sure it still works with a "standard" configuration? -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
