Le jeu. 22 avr. 2021 à 16:06, Raymond Augé <raymond.a...@liferay.com.invalid>
a écrit :

> @ServiceProvider is just a hint no?
>

Hmm, didn't check the tomcat specific setup but thought it was adding
META-INF/services/xxxx entry too which is current issue.
Seems you are right and
https://github.com/apache/tomcat/blob/master/res/META-INF/tomcat-websocket.jar/services/jakarta.websocket.server.ServerEndpointConfig$Configurator
is just "there".


>
> It does not change the implementation behavior... Unless you've found
> otherwise, which would be surprising.
>

If it does not add the file all good and we can drop
https://github.com/apache/tomcat/blob/master/res/META-INF/tomcat-websocket.jar/services/jakarta.websocket.server.ServerEndpointConfig$Configurator
all good for me


>
> Ray
>
> On Thu., Apr. 22, 2021, 9:29 a.m. Romain Manni-Bucau, <
> rmannibu...@gmail.com>
> wrote:
>
> > Hi all,
> >
> > Websocket server configurator uses the SPI to load the impl and if not
> > found fallbacks on the hardcoded tomcat default.
> > Isn't the SPI intended to override the default and
> > therefore @ServiceProvider breaks this feature?
> > If not, how to override it globally without doing it on a per endpoint
> > basis?
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> > https://github.com/rmannibucau> |
> > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
> >
>

Reply via email to