https://bz.apache.org/bugzilla/show_bug.cgi?id=65340

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |enhancement

--- Comment #3 from Mark Thomas <ma...@apache.org> ---
I'd like to know if this is a Tomcat decoding bug or a Jetty encoding bug.
Please re-create the issue over h2c and provide a tcpdump of the failed
request. Until there is evidence this is a Tomcat bug, I am marking this as an
enhancement.

Additional debug logging is always useful. Proposed changes should be provided
in diff -u format.

The proposed change is hard to read because it isn't provided as a patch but I
note the following:
- patch should use Tomcat's logging framework
- patch should use Tomcat's StringManager
- no need to wrap caught exception - just catch RuntimeException and re-throw
- I'm not sure (I'd need to check the HPACK spec) if conversion to string is
appropriate in all cases. It may be better to log the bytes (See
HexUtils.toHexString(byte[])

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to