https://bz.apache.org/bugzilla/show_bug.cgi?id=65351

Remy Maucherat <r...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Remy Maucherat <r...@apache.org> ---
(In reply to cklein05 from comment #1)
> Provided method was not complete, in order to test for all/effective roles,
> of course (my bad). Testing explicitly assigned roles is still required so,
> this should be the correct version:

Makes sense. I simply took the original hasRole override code I removed for no
reason. Seems like a case of badcutandpaste-itis.

We still need to decide on what to do with the database realm, since without an
expansion to more database types I cannot see what it can be used for.

> public boolean isInEffectiveRole(Role role) {
>   if (isInRole(role)) {
>     return true;
>   }
>   synchronized (groups) {
>     for (Group group : groups) {
>       if (group.isInRole(role)) {
>         return true;
>       }
>     }
>   }
>   return false;
> }

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to