cklein05 commented on a change in pull request #428: URL: https://github.com/apache/tomcat/pull/428#discussion_r654976453
########## File path: java/org/apache/catalina/realm/DataSourceRealm.java ########## @@ -539,6 +612,162 @@ private boolean isRoleStoreDefined() { } + /** + * Return the specified user's requested user attributes as a map. + * + * @param dbConnection The database connection to be used + * @param username User name for which to return user attributes + * + * @return a map containing the specified user's requested user attributes + */ + protected Map<String, Object> getUserAttributesMap(Connection dbConnection, String username) { + + String preparedAttributes = getUserAttributesStatement(dbConnection); + if (preparedAttributes == null || preparedAttributes == USER_ATTRIBUTES_NONE_REQUESTED) { Review comment: Ah, `isEmpty()` is clearly better. Didn't have that method in mind (only thought of `preparedAttributes.length() == 0` and wanted something more _speaking_). Would you keep the `USER_ATTRIBUTES_NONE_REQUESTED` constant anyway? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org