Mark,
On 8/9/21 16:05, Mark Thomas wrote:
The proposed Apache Tomcat 8.5.70 release is now available for voting.
Chris was having some difficulties before the weekend getting the
release to build. He hasn't had time to get to the bottom of these
issues and time is ticking on so I took a look. I had different issues
on Windows but was still unable to complete the release. With the
addition of JSign, we have the option to build a full release on Linux
so I tried that and it was successful. If successful, this will be the
first release for a very long time built on Linux.
Given the above, additional scrutiny on the release artefacts targetted
at Windows would be welcome.
The notable changes compared to the 8.5.69 release are:
- Correct a regression in the previous release in the HTTP/2 flow
control window management along with additional improvements to HTTP/2
flow control
- Make the CorsFilter simpler to extend
- To avoid unnecessary cache revalidation, do not add an HTTP Expires
header when setting adding an HTTP header of CacheControl: private
Along with lots of other bug fixes and improvements.
For full details, see the changelog:
https://ci.apache.org/projects/tomcat/tomcat-8.5.x/docs/changelog.html
It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.70/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1329/
The tag is:
https://github.com/apache/tomcat/tree/8.5.70
3d2e8b1964d4dff3c0656618edc0b09d0d5634b8
The proposed 8.5.70 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.70
Thanks for RM'ing.
I won't veto the release, but it appears that you signed the (non-Maven)
release artifacts with an expired PGP key. I'm not even sure how that's
possible (GPG should refuse to do such things). Before release, I would
recommend replacing the *.asc files; the originals obviously do not need
to change. I did not check the Maven artifacts for similar issues.
Works on a mundane servlet-based application in a development
environment with no obvious issues.
There are some unit-test failures. Some are entirely expected though
others are not. I'll leave it up to you to decide if these are problematic:
* org.apache.catalina.valves.rewrite.TestResolverSSL.NIO.txt
* org.apache.catalina.valves.rewrite.TestResolverSSL.NIO2.txt
* (but not APR)
* (fails due to readApplicationRecord error; OpenSSL version issue?)
* org.apache.tomcat.util.net.TestClientCert.NIO.txt
* org.apache.tomcat.util.net.TestClientCert.NIO2.txt
* org.apache.tomcat.util.net.TestClientCertTls13.APR.txt
* org.apache.tomcat.util.net.TestClientCertTls13.NIO.txt
* org.apache.tomcat.util.net.TestClientCertTls13.NIO2.txt
* (also readApplicationRecord issues)
My guess is that since I'm using OpenSSL 1.1.1 and not OpenSSL 3.0.x, so
certain things are missing that we are testing.
Thanks,
-chris
Details:
* Environment
* Java (build): openjdk version "1.8.0_292" OpenJDK Runtime
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
Server VM (build 25.292-b10, mixed mode)
* Java (test): openjdk version "1.8.0_292" OpenJDK Runtime
Environment (build 1.8.0_292-8u292-b10-0+deb9u1-b10) OpenJDK 64-Bit
Server VM (build 25.292-b10, mixed mode)
* OS: Linux 4.19.0-17-amd64 x86_64
* cc: cc (Debian 8.3.0-6) 8.3.0
* make: GNU Make 4.2.1
* OpenSSL: OpenSSL 1.1.1 11 Sep 2018
* APR: 1.6.5
*
* Valid SHA-512 signature for apache-tomcat-8.5.70.zip
* !! Invalid GPG signature for apache-tomcat-8.5.70.zip
* Valid SHA-512 signature for apache-tomcat-8.5.70.tar.gz
* !! Invalid GPG signature for apache-tomcat-8.5.70.tar.gz
* Valid SHA-512 signature for apache-tomcat-8.5.70.exe
* !! Invalid GPG signature for apache-tomcat-8.5.70.exe
* Valid Windows Digital Signature for apache-tomcat-8.5.70.exe
* Valid SHA512 signature for apache-tomcat-8.5.70-src.zip
* !! Invalid GPG signature for apache-tomcat-8.5.70-src.zip
* Valid SHA512 signature for apache-tomcat-8.5.70-src.tar.gz
* !! Invalid GPG signature for apache-tomcat-8.5.70-src.tar.gz
*
* Binary Zip and tarball: !! NOT SAME
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt
* org.apache.catalina.valves.rewrite.TestResolverSSL.NIO.txt
* org.apache.catalina.valves.rewrite.TestResolverSSL.NIO2.txt
* org.apache.tomcat.util.net.TestClientCert.NIO.txt
* org.apache.tomcat.util.net.TestClientCert.NIO2.txt
* org.apache.tomcat.util.net.TestClientCertTls13.APR.txt
* org.apache.tomcat.util.net.TestClientCertTls13.NIO.txt
* org.apache.tomcat.util.net.TestClientCertTls13.NIO2.txt
* org.apache.tomcat.util.net.TestCustomSsl.NIO.txt
* org.apache.tomcat.util.net.TestCustomSsl.NIO2.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
