ppkarwasz commented on PR #544:
URL: https://github.com/apache/tomcat/pull/544#issuecomment-1220013953
@markt-asf,
As far as I can see, the `LoggerThread` is the only part of JULI that needs
to be concerned with `Throwable`s. I inline the relevant part of
`ExceptionUtils#handleException`. A stack overflow is not a problem in this
case, since we are in a thread's `run` method.
On the other hand I would be tempted to replace `LoggerThread` entirely
with a single threaded `ExecutorService` as in
[new-async-file-handler](https://github.com/ppkarwasz/tomcat/tree/new-async-file-handler).
That solution will require much more testing, but will solve another potential
problem: the `LoggerThread` can have as context classloader the classloader of
a web application.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
