DanielThomas commented on code in PR #36: URL: https://github.com/apache/tomcat-jakartaee-migration/pull/36#discussion_r1005100601
########## src/main/java/org/apache/tomcat/jakartaee/ManifestConverter.java: ########## @@ -112,7 +107,7 @@ private boolean updateValues(Attributes attributes, EESpecProfile profile) { if (attributes.containsKey(Attributes.Name.IMPLEMENTATION_VERSION)) { String newValue = attributes.get(Attributes.Name.IMPLEMENTATION_VERSION) + "-" + Info.getVersion(); attributes.put(Attributes.Name.IMPLEMENTATION_VERSION, newValue); - result = true; + // Purposefully avoid setting result Review Comment: This is metadata and would cause every file to be considered converted, even if no interesting conversions took place. The destination manifest is written regardless with this change. Omitting this is what allows `hasConverted()` to work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org