вт, 7 мар. 2023 г. в 10:14, Han Li <li...@apache.org>: > > > > > On Mar 7, 2023, at 14:39, Konstantin Kolinko <knst.koli...@gmail.com> wrote: > > > > вт, 7 мар. 2023 г. в 09:17, <li...@apache.org <mailto:li...@apache.org>>: > >> > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> lihan pushed a commit to branch main > >> in repository https://gitbox.apache.org/repos/asf/tomcat.git > >> > >> > >> The following commit(s) were added to refs/heads/main by this push: > >> new 1fc4b7c95d Align with spec > >> 1fc4b7c95d is described below > >> > >> commit 1fc4b7c95dce1db3d86db9393c78023b93725f63 > >> Author: lihan <li...@apache.org> > >> AuthorDate: Tue Mar 7 14:16:53 2023 +0800 > >> > >> Align with spec > > > > -1 (veto) > > > > Please revert. > Ok. > > > > The text of the specification comes with a license. > > > > I have not checked recently (with the spec is managed by Eclipse > > Foundation), but in earlier times (for specs copyrighted by Oracle) it > > was clear that you were not allowed to copy their text as you wish. > > > > You are not the first one to make such changes. There were similar > > discussions in earlier years. > > I probably understand what means, and I have another question that if I just > align code with spec there’s no problem, right? >
Regarding javadoc, I think it is OK to document what Tomcat does. (What it has to do is dictated by the spec, but what it actually does is our implementation details, and can be documented). Regarding code, If you are talking about alignment of method signatures, those should already have been aligned. I know that the TCK (i.e. the set of tests that comes with specification) has tests that check signatures of all methods. As Tomcat was tested with TCK some time ago, I think those methods have already been tested. If you are talking about alignment of implementation details, there is no reason to do so, The specification is just a document (pdf) plus javadoc (and method signatures documented there), and a set of tests (TCK). If you are looking at the code that comes with the spec, that code is just a "reference implementation", serves as an example and does not define any required behaviour. If there is a bug, i.e. behaviour of Tomcat differs with that is dictated by official javadoc, it is a bug, and should be fixed as such. Best regards, Konstantin Kolinko --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
