On 05/04/2023 13:01, Mark Thomas wrote:
Good news and bad news.
The good news is that the issues were with the test. The test has to use
statics to pass data to Endpoint instances and they weren't being reset
properly between tests. With that fixed there were 2 failures that are
both fixed by the proposed patch.
The bad news is that the proposed patch fixes one possible cause of the
deadlock but introduces another.
I'm working on an updated patch.
I have a fix but...
The proposed patch for BZ 66508 (both the original and the updated
patch) depend on the change from synchronizing on socketWrapper to using
a ReentrantLock. This change was made to 10.1.x onwards to support Loom
experiments but was not back-ported to 9.0.x and earlier.
https://github.com/apache/tomcat/commit/0a9480158874ea910a4d629d24f31d69d6cc5f96
What do folks think about back-porting this change to 9.0.x and 8.5.x?
Mark
Mark
On 04/04/2023 20:23, Mark Thomas wrote:
Hi all,
I now have a test case for BZ 66508. Having parameterized it for
NIO/NIO2, useAsyncIO = true/false and sending messages from the server
on a container thread or not I think I am making progress.
Without the patch 6 out of 8 tests fail.
With the patch 3 out of 8 tests fail.
I'm not sure if the problem lies with the new test or with Tomcat at
this point.
At this point tomorrow is my most optimistic estimate of when I'll be
able to tag 11.0.x.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
